Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alibi deployment example - Anchor Tabular #629

Merged
merged 3 commits into from
Jul 5, 2019

Conversation

axsaucedo
Copy link
Contributor

Alibi Anchor Tabular Seldon Deployment Example

This PR contains an example of an Alibi Anchor Tabular deployment, building upon the CogX Demo showcasing the income classifier example. The example can be found through the README in the base folder, as well as directly through the Jupyter Notebook provided.

The objective of this example is to serve as a basis of an end-to-end example that works with Kubeflow, as well as with further showcase with Seldon Deploy without much customisation. Furthermore, this has been very useful to also extend the existing Kubeflow NLP End-to-end example to showcase a full end-to-end explainer demo on the Anchor Text.

The architecture of the example is the following:

Copy link
Contributor

@jklaise jklaise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • clf.fit(preprocessor.transform(X_train), Y_train) --> needs to be y_train
  • can we use the latest s2-wrapper? (0.8)
  • don't forget to port-forward ambassador and supply port (localhost:port, or otherwise specify nodeport is needed?)
  • was getting timeouts with the default manifest config, so added a higher timeout, but the explanation just hangs for several minutes on the given test instance before timing out again - need to investigate what's going on
  • resp = sc_pred.predict --> needs to be resp = sc.predict
  • y_valid is not defined
  • sc_xai should be sc?

@axsaucedo
Copy link
Contributor Author

Thanks for the comments @jklaise! I've addressed them now 👍

@axsaucedo
Copy link
Contributor Author

As an update, @jklaise has gone through this PR, but has encountered issues when running the explainer due to version missmatch between the local and remote environemnts. I have worked with @jklaise to solve this, but I am not able to replicate this issue, even with a clean conda install. @gsunner or @ryandawsonuk could have a look and see if it works properly for you?

@jklaise jklaise merged commit 43bc044 into SeldonIO:master Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants